linux-kernel - Re: [PATCH RESEND V4 1/4] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 22:11:31 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Feng Kan <fkan@....com>
Cc:	patches@....com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-i2c@...r.kernel.org, Hieu Le <hnle@....com>
Subject: Re: [PATCH RESEND V4 1/4] i2c: busses: add SLIMpro I2C device driver
 on APM X-Gene platform

On Fri, Apr 24, 2015 at 03:17:50PM -0700, Feng Kan wrote:
> Add SLIMpro I2C device driver on APM X-Gene platform. This I2C
> device driver use the SLIMpro Mailbox driver to tunnel message to
> the SLIMpro coprocessor to do the work of accessing I2C components.
> 
> Signed-off-by: Feng Kan <fkan@....com>
> Signed-off-by: Hieu Le <hnle@....com>

Applied to for-next, thanks!

One comment though:

> +	adapter->class = I2C_CLASS_HWMON;

Since you have DT and ACPI, you most likely won't need that, or?
It speeds up boot time if you don't use classes. Send me an incremental
patch if you want to change this.


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)