linux-kernel - Re: [PATCH v3 07/33] staging: rtl8192e: Replace RTLLIB_DEBUG(DL_ERR) with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555265E6.4000400@gmail.com>
Date:	Tue, 12 May 2015 22:43:18 +0200
From:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
CC:	gregkh@...uxfoundation.org, dan.carpenter@...cle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 07/33] staging: rtl8192e: Replace RTLLIB_DEBUG(DL_ERR)
 with netdev_*()

On 10.05.2015 09:53, Sudip Mukherjee wrote:
> On Sat, May 09, 2015 at 11:18:55PM +0200, Mateusz Kulikowski wrote:
>> Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
>> for errors that really should be reported to user.
>> Use netdev_warn() for the rest.
>> Rephrase some of the messages to make them more readable/compact.
> checkpatch is saying :
> CHECK: Alignment should match open parenthesis
> #332: FILE: drivers/staging/rtl8192e/rtl819x_TSProc.c:82:
> +			netdev_warn(ieee->dev,
> +				   "%s(): Rx Reorder struct buffer full\n",
> 

That's clearly a typo - thanks - will fix it - checkpatch didn't noticed 
that in non-strict mode.

Regards,
Mateusz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/