linux-kernel - Re: [PATCH 1/5] selftests: Add futex functional tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55526DF1.1020103@osg.samsung.com>
Date:	Tue, 12 May 2015 15:17:37 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Darren Hart <dvhart@...ux.intel.com>,
	Cyril Hrubis <chrubis@...e.cz>
CC:	linux-api@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	John Stultz <john.stultz@...aro.org>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Davidlohr Bueso <dave@...olabs.net>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 1/5] selftests: Add futex functional tests

On 05/12/2015 02:54 PM, Darren Hart wrote:
> On 5/12/15, 1:40 PM, "Shuah Khan" <shuahkh@....samsung.com> wrote:
> 
>> On 05/12/2015 02:15 PM, Darren Hart wrote:
>>> On 5/12/15, 1:05 PM, "Cyril Hrubis" <chrubis@...e.cz> wrote:
>>>
>>>> Hi!
>>>>>>> I'm happy to do that, but I would like to make sure I'm doing the
>>>>> right
>>>>>>> thing.
>>>>>>
>>>>>> The right thing here is to add -pthread to CFLAGS which sets both
>>>>>> flags
>>>>>> for preprocessor and linker (see man gcc).
>>>>>
>>>>> Hi Cyril,
>>>>>
>>>>> Thanks. I read that, and mentioned it, but my concern with -pthread in
>>>>> the
>>>>> CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I
>>>>> understand we have a number of gcc-isms in our build - but do we want
>>>>> to
>>>>> add more?
>>>>>
>>>>> I'm also struggling to find any kind of prescribed documentation on
>>>>> this
>>>>> beyond the short blurb in the gcc man page which describes what this
>>>>> option does, but not when to use it. I'll need something concrete to
>>>>> justify changes to testcase Makefiles to Shuah.
>>>>
>>>> Sorry to mislead you with the pointing at gcc man page.
>>>>
>>>> It is a Linux standard. Have a look at pthreads manual page:
>>>> http://man7.org/linux/man-pages/man7/pthreads.7.html
>>>>
>>>> "On Linux, programs that use the Pthreads API should be compiled using
>>>> cc -pthread."
>>>>
>>>> Or any pthread_foo() manual page that starts with:
>>>>
>>>> "Compile and link with -pthread."
>>>>
>>>> The portable way i.e. POSIX would be getting compiler flags with
>>>> getconf
>>>> but as this is a Linux kernel testsuite I would not bother with that.
>>>> Hmm, and it looks like this is not implemented on Linux anyway.
>>>
>>> Thanks Cyril, that's perfect.
>>>
>>> I'll roll my latest example patch adding -pthread to LDFLAGS and CFLAGS
>>> into the initial patch and resubmit the patch series as v4.
>>>
>>
>> Daren,
>>
>> While you are generating new version, could you also please add
>> .gitignore for the futex binaries, so they get ignored by git.
> 
> Will do.
> 

Daren,

Do you plan to add futex test install support in a later patch
series? When you sent this patch series, install support was
work in progress. 4.1 has the kselftest install feature.

Feel free to defer it for a later patch series if you like. Would
be good to get the futex install support into 4.2 if it is possible.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/