linux-kernel - Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150513044550.GA3428@sudip-PC>
Date:	Wed, 13 May 2015 10:15:50 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	gregkh@...uxfoundation.org, dan.carpenter@...cle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning
 in rtllib_parse_info_param()

On Tue, May 12, 2015 at 11:01:44PM +0200, Mateusz Kulikowski wrote:
> On 10.05.2015 09:49, Sudip Mukherjee wrote:
> > On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
> 
> You're running checkpatch --strict right?
> 
> > 1) multiple blank lines
> > 2) Blank lines aren't necessary before a close brace
> > 3) spaces preferred around that '+'
> 
> I will fix them (as they're pretty straightforward), and will 
> probably do --strict checks for my patches in future;
I think --strict is the suggested way of checking.
And if i remember correctly it was once discussed to make --strict the
default mode, but I think that was never done.
> 
> I will not fix more complex checks in such cases, because patch like this
> was supposed to simplify function (i.e. split it) - without changing 
> it's code too much.
> 
> Is it ok with you?
ofcourse, checkpatch also complained about many other things, but they
will need separate patch to correct.

regards
sudip
> 
> Regards,
> Mateusz
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/