| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 May 2015 15:54:44 +0900 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Tero Kristo <t-kristo@...com>, Mike Turquette <mturquette@...aro.org>, Stephen Boyd <sboyd@...eaurora.org>, linux-omap@...r.kernel.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com> Subject: [RFT PATCH 5/8] clk: ti: clk-43xx: Prevent possible ERR_PTR dereference The return value of clk_get_sys() was immediately used in clk_set_parent(). The first one may return ERR_PTR and the latter only checks if supplied argument is non-NULL. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> --- drivers/clk/ti/clk-43xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/ti/clk-43xx.c b/drivers/clk/ti/clk-43xx.c index 3795fce8a830..c6e1fc704052 100644 --- a/drivers/clk/ti/clk-43xx.c +++ b/drivers/clk/ti/clk-43xx.c @@ -134,7 +134,8 @@ int __init am43xx_dt_clk_init(void) */ clk1 = clk_get_sys(NULL, "cpsw_cpts_rft_clk"); clk2 = clk_get_sys(NULL, "dpll_core_m5_ck"); - clk_set_parent(clk1, clk2); + if (!IS_ERR(clk1) && !IS_ERR(clk2)) + clk_set_parent(clk1, clk2); return 0; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists