linux-kernel - [PATCH] sgi-gru: fix null pointer dereference on failed kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1431505186-22628-1-git-send-email-colin.king@canonical.com>
Date:	Wed, 13 May 2015 09:19:46 +0100
From:	Colin King <colin.king@...onical.com>
To:	Dimitri Sivanich <sivanich@....com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] sgi-gru: fix null pointer dereference on failed kzalloc

From: Colin Ian King <colin.king@...onical.com>

static analysis from smatch found a potential null dereference:

drivers/misc/sgi-gru/grutlbpurge.c:320 gru_register_mmu_notifier() error:
  potential null dereference 'gms'.  (kzalloc returns null)

bail out with -ENOMEM rather than falling through and printing a debug
message that trips a null dereference.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/misc/sgi-gru/grutlbpurge.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/misc/sgi-gru/grutlbpurge.c b/drivers/misc/sgi-gru/grutlbpurge.c
index 2129274..1239800 100644
--- a/drivers/misc/sgi-gru/grutlbpurge.c
+++ b/drivers/misc/sgi-gru/grutlbpurge.c
@@ -315,6 +315,8 @@ struct gru_mm_struct *gru_register_mmu_notifier(void)
 			err = __mmu_notifier_register(&gms->ms_notifier, current->mm);
 			if (err)
 				goto error;
+		} else {
+			return ERR_PTR(-ENOMEM);
 		}
 	}
 	gru_dbg(grudev, "gms %p, refcnt %d\n", gms,
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/