linux-kernel - Re: [PATCH v4 02/13] ARM: dts: exynos4: Use labels for overriding nodesin Exynos4210

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55531E9E.2030805@gmail.com>
Date:	Wed, 13 May 2015 18:51:26 +0900
From:	Krzysztof Kozlowski <k.kozlowski.k@...il.com>
To:	Kukjin Kim <kgene@...nel.org>
CC:	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 02/13] ARM: dts: exynos4: Use labels for overriding
 nodesin Exynos4210

W dniu 13.05.2015 o 18:02, Kukjin Kim pisze:
> On 05/11/15 22:42, Krzysztof Kozlowski wrote:
>> Usage of labels instead of full paths reduces possible mistakes when
>> overriding nodes.
>>
> Well, I'm not sure what kind of the possible mistakes you mentioned...?

One can make a mistake in path when overriding. For example we have:
exynos4.dtsi:
/ {
	gic: interrupt-controller@...90000 {
		...
	};
}

and someone can add in child dtsi (like exynos4210.dtsi):
/ {
	soc {
		interrupt-controller@...90000 {
			cpu-offset = <0x8000>;
		}
	}
}

or he can make a mistake in address.

As a result the gic node won't be properly overridden.

> 
> I don't think we need to use the label for gic, combiner.

They are overridden by child DTSI. First definition is in exynos4.dtsi
and exynos4210.dtsi adds a cpu-offset.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/