linux-kernel - Re: [PATCH v1] lib/sort: Add 64 bit swap function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55533561.4090001@bmw-carit.de>
Date:	Wed, 13 May 2015 13:28:33 +0200
From:	Daniel Wagner <daniel.wagner@...-carit.de>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	<akpm@...ux-foundation.org>
CC:	<mm-commits@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] lib/sort: Add 64 bit swap function

On 05/13/2015 01:00 PM, Daniel Wagner wrote:
> static int cmp_72(const void *a, const void *b)
> {
> 	u32 l = get_unaligned((u32 *) a);
> 	u32 r = get_unaligned((u32 *) b);
> 
> 	if (l < r)
> 		return -1;
> 	if (l > r)
> 		return -1;
> 	return 0;
> }

Argh, obviously wrong. Should I send a fix? The numbers do not change.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/