linux-kernel - Re: [PATCH] block:Change the function,nvme_alloc_queue to use -ENOMEM for when failing memory allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 13 May 2015 09:32:52 -0400
From:	Matthew Wilcox <willy@...ux.intel.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block:Change the function,nvme_alloc_queue to use
 -ENOMEM for when failing memory allocations

On Tue, May 12, 2015 at 07:51:31PM -0400, Nicholas Krause wrote:
> This changes the function,nvme_alloc_queue to use the kernel code,
> -ENOMEM for when failing to allocate the memory required for the
> nvme_queue structure pointer,nvme in order to correctly return
> to the caller the correct reason for this function's failing.

>  	if (!nvmeq)
> -		return NULL;
> +		return -ENOMEM;
>  

You didn't even compile-test this, did you?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/