linux-kernel - Re: [patch v2] checkpatch: complain about GW-BASIC style label names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150513141232.GC7232@ZenIV.linux.org.uk>
Date:	Wed, 13 May 2015 15:12:32 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch v2] checkpatch: complain about GW-BASIC style label names

On Wed, May 13, 2015 at 03:37:12PM +0300, Dan Carpenter wrote:
> GW-BASIC style label names are annoying so we can warn about that in
> checkpatch.  The warnings look like:
> 
> 	WARNING: 'fail2' isn't informative - prefer descriptive label names
> 	#267: FILE: ./sound/ppc/beep.c:267:
> 	+ fail2:        snd_ctl_remove(chip->card, beep_ctl);
> 
> This generates slightly under 2000 new warnings.  None of them are
> false positives.

And all of them are complete garbage.  Please, stop forcing your personal
preferences upon the rest of us.

Any "fixes" of that sort in fs/*.c will be passed straight to /dev/null.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/