linux-kernel - Re: [PATCH] blk: don't account discard request size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55536C46.4020304@fb.com>
Date:	Wed, 13 May 2015 11:22:46 -0400
From:	Jens Axboe <axboe@...com>
To:	Jeff Moyer <jmoyer@...hat.com>
CC:	Shaohua Li <shli@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] blk: don't account discard request size

On 05/13/2015 11:00 AM, Jeff Moyer wrote:
> Jens Axboe <axboe@...com> writes:
>
>> That would be better. But I'm still not sure we want to turn off
>> accounting for discards. For the mixed write/discard cases it's
>> definitely confusing. The better option would be to account it as a
>> discard and not a write. Preferably in a way that would not break
>> existing tools, but so that they could get updated to support it.
>
> Are you suggesting adding a few fields to the end of diskstats or adding
> a new proc file altogether?  (or something else?)

I didn't suggest any specific solution. Obviously it'd be nice if we 
could just extend diskstats, but that might break userland. Worth 
checking up on.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/