| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <x49zj584gwn.fsf@segfault.boston.devel.redhat.com> Date: Wed, 13 May 2015 11:48:56 -0400 From: Jeff Moyer <jmoyer@...hat.com> To: Jens Axboe <axboe@...com> Cc: Shaohua Li <shli@...com>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] blk: don't account discard request size Jens Axboe <axboe@...com> writes: > On 05/13/2015 11:00 AM, Jeff Moyer wrote: >> Jens Axboe <axboe@...com> writes: >> >>> That would be better. But I'm still not sure we want to turn off >>> accounting for discards. For the mixed write/discard cases it's >>> definitely confusing. The better option would be to account it as a >>> discard and not a write. Preferably in a way that would not break >>> existing tools, but so that they could get updated to support it. >> >> Are you suggesting adding a few fields to the end of diskstats or adding >> a new proc file altogether? (or something else?) > > I didn't suggest any specific solution. Obviously it'd be nice if we > could just extend diskstats, but that might break userland. Worth > checking up on. OK, I didn't know if you had any other tricks up your sleeve. We've had luck adding fields to the end of some files in the past (I'd really have to dig to remember what files), but I'm fairly certain this would break *something*. It's definitely safer (albeit uglier) to just add a file. -Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists