linux-kernel - Re: [PATCH 2/4] ASoC: rockchip: add rockchip machine driver for max98090

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150513164738.GC2761@sirena.org.uk>
Date:	Wed, 13 May 2015 17:47:38 +0100
From:	Mark Brown <broonie@...nel.org>
To:	zhengxing <zhengxing@...k-chips.com>
Cc:	Xing Zheng <acgzxing@...il.com>, dgreid@...omium.org,
	dianders@...omium.org, heiko@...ech.de, sonnyrao@...omium.org,
	linux-rockchip@...ts.infradead.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/4] ASoC: rockchip: add rockchip machine driver for
 max98090

On Wed, May 13, 2015 at 09:23:20PM +0800, zhengxing wrote:
> On 2015年05月13日 03:26, Mark Brown wrote:

> >This looks more like a normal and reasonable machine driver but then why
> >have you created the generic rockchip machine driver?  It seems like
> >this should just be a regular machine driver like other platforms have,
> >were it not for that this would be mostly fine apart from a couple of
> >nitpicks below.

> We just use rockchip_machine_driver to describe the supported codecs base on
> origianl way, vendor machine driver(rockchip_max98090) will achieve
> functions.

Like I said in reply to the other message I just don't understand what
you're saying here - take a look at the various Tegra machine drivers
for example, they also have per-CODEC handling but they just use normal
machine drivers to do it.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)