linux-kernel - Re: [PATCH v2 0/3] Dell Airplane Mode Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 May 2015 11:38:22 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Alex Hung <alex.hung@...onical.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	Gabriele Mazzotta <gabriele.mzt@...il.com>
Subject: Re: [PATCH v2 0/3] Dell Airplane Mode Switch driver

On Wed, May 13, 2015 at 01:48:41PM +0200, Pali Rohár wrote:
> Darren, can you review/comment this v2 series? It is OK for 4.2 now?
> 

I thought I was waiting on an Ack from Alex but reviewing the various threads I
think he's OK with this.

Running the patches through checkpatch reports various issues about tabs
(resolved by using proper multi-line comment formatting), line length, and not
wrapping strings. I corrected these locally to move things along, but when
building:

  CC [M]  drivers/platform/x86/dell-rbtn.o
drivers/platform/x86/dell-rbtn.c: In function ‘dell_rbtn_notifier_register’:
drivers/platform/x86/dell-rbtn.c:273:2: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result [-Wunused-result]
  driver_for_each_device(&rbtn_driver.drv, NULL, &ret, rbtn_inc_count);
  ^
drivers/platform/x86/dell-rbtn.c:284:3: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result [-Wunused-result]
   driver_for_each_device(&rbtn_driver.drv, NULL, (void *)false,
   ^
drivers/platform/x86/dell-rbtn.c: In function ‘dell_rbtn_notifier_unregister’:
drivers/platform/x86/dell-rbtn.c:300:3: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result [-Wunused-result]
   driver_for_each_device(&rbtn_driver.drv, NULL, (void *)true,

We can't introduce new warnings to the build.

I've pushed my fixes to the series to my dell-rbtn branch, please start from
there and resolve the above, and resubmit. We can still make 4.2. But please
make use of checkpatch and watch for warnings like the above in your builds
tests so we can avoid unecessary churn.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/