lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4603623.ImT6VbfUHq@wuerfel>
Date:	Wed, 13 May 2015 21:03:29 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Hans Ulli Kroll <ulli.kroll@...glemail.com>
Cc:	Paul Bolle <pebolle@...cali.nl>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 1/1] RTC:driver for Cortina's SOC

On Wednesday 13 May 2015 20:23:40 Hans Ulli Kroll wrote:
> > I have a patch that will turn mach-gemini into multiplatform, and
> > at that point it will also fail there. The correct solution I think
> > is to move the GEMINI_RTC_SECOND etc definitions into rtc-gemini.c
> > itself and remove the #include.
> > 
> 
> GEMINI_RTC_SECOND and other register offset are in the driver.
> The only address I get from the #include is the base address of the RTC
> 

Ah, I see. Please pass a struct resource for this then when you call
platform_device_register_simple from the platform code, and
use platform_get_resource/devm_ioremap_resource to map it so you can
remove that inclusion.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ