linux-kernel - Re: [PATCH] leds: fix brightness changing when software blinking is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55546EAC.70408@list.ru>
Date:	Thu, 14 May 2015 12:45:16 +0300
From:	Stas Sergeev <stsp@...t.ru>
To:	Jacek Anaszewski <j.anaszewski@...sung.com>
CC:	linux-leds@...r.kernel.org,
	Linux kernel <linux-kernel@...r.kernel.org>,
	Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Stas Sergeev <stsp@...rs.sourceforge.net>
Subject: Re: [PATCH] leds: fix brightness changing when software blinking
 is active

14.05.2015 11:44, Jacek Anaszewski пишет:
> 
>>       if (led_cdev->blink_delay_on || led_cdev->blink_delay_off) {
>>           led_cdev->delayed_set_value = brightness;
>> -        schedule_work(&led_cdev->set_brightness_work);
> 
> This line is still required. Please refer to the patch d23a22a74.
But I really want to get rid of this line and
vacate the work-queue, so that in the future the
per-driver work-queues can be replaced with this.

Why do you think it is still needed?
Are there any valid cases where you need to disable the
soft-blink from hard-irq context? IMHO the soft-blink is
only disabled as a result of user's actions, which is not
in a hard-irq context.
Could you please explain the use-case?

>>       /* Stop blinking */
>> +    led_stop_software_blink(led_cdev);
> This won't be needed.
Indeed, but with these changes there should be no requirement
for disabling a soft-blink from hard-irq context, which is what
I really wanted to have. What am I missing?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/