linux-kernel - Re: [PATCH 1/1 linux-next] configfs: unexport/make static config_item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZDyz4Egvv+tAdT0mX4qWKihOduG=w+wP=kgbscv-wpAMQ@mail.gmail.com>
Date:	Thu, 14 May 2015 13:41:25 +0300
From:	Daniel Baluta <daniel.baluta@...il.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joel Becker <jlbec@...lplan.org>
Subject: Re: [PATCH 1/1 linux-next] configfs: unexport/make static config_item_init()

On Wed, Apr 29, 2015 at 8:01 PM, Fabian Frederick <fabf@...net.be> wrote:
> config_item_init() is only used in item.c
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Nack! Have a look at drivers/usb/gadget/configfs.c
> ---
>  fs/configfs/item.c       | 3 +--
>  include/linux/configfs.h | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/configfs/item.c b/fs/configfs/item.c
> index e65f9ff..4d6a30e 100644
> --- a/fs/configfs/item.c
> +++ b/fs/configfs/item.c
> @@ -47,12 +47,11 @@ static void config_item_release(struct kref *kref);
>   *     config_item_init - initialize item.
>   *     @item:  item in question.
>   */
> -void config_item_init(struct config_item *item)
> +static void config_item_init(struct config_item *item)
>  {
>         kref_init(&item->ci_kref);
>         INIT_LIST_HEAD(&item->ci_entry);
>  }
> -EXPORT_SYMBOL(config_item_init);
>
>  /**
>   *     config_item_set_name - Set the name of an item
> diff --git a/include/linux/configfs.h b/include/linux/configfs.h
> index 34025df..c9e5c57 100644
> --- a/include/linux/configfs.h
> +++ b/include/linux/configfs.h
> @@ -71,7 +71,6 @@ static inline char *config_item_name(struct config_item * item)
>         return item->ci_name;
>  }
>
> -extern void config_item_init(struct config_item *);
>  extern void config_item_init_type_name(struct config_item *item,
>                                        const char *name,
>                                        struct config_item_type *type);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/