linux-kernel - Re: [PATCH] netfilter: ipset: deinline ip_set_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150514105605.GA4852@salvia>
Date:	Thu, 14 May 2015 12:56:05 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Jan Engelhardt <jengelh@...ozas.de>,
	Jiri Pirko <jpirko@...hat.com>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH] netfilter: ipset: deinline ip_set_put_extensions()

On Wed, May 06, 2015 at 04:28:57PM +0200, Denys Vlasenko wrote:
> On x86 allyesconfig build:
> The function compiles to 489 bytes of machine code.
> It has 25 callsites.
> 
>     text    data       bss       dec     hex filename
> 82441375 22255384 20627456 125324215 7784bb7 vmlinux.before
> 82434909 22255384 20627456 125317749 7783275 vmlinux

Jozsef, I'm going to applied this patch to nf-next.

I think that things like ip_set_put_skbinfo() can be also deinlined
and move to the core as exported symbol as this run from the control
plane path (ie. netlink).

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/