linux-kernel - Re: [PATCH V2] atmel: fix a race between fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55548784.3080505@itdev.co.uk>
Date:	Thu, 14 May 2015 12:31:16 +0100
From:	Nick Dyer <nick.dyer@...ev.co.uk>
To:	Pan Xinhui <xinhuix.pan@...el.com>, linux-kernel@...r.kernel.org
CC:	dmitry.torokhov@...il.com, yanmin_zhang@...ux.intel.com,
	mnipxh@....com
Subject: Re: [PATCH V2] atmel: fix a race between fw_load and data free

Hi-

This looks like a good tidy up, one minor comment:

On 15/05/15 12:19, Pan Xinhui wrote:
> +    mxt_wait_for_completion(data, &data->fw_load_completion,
> +                    MXT_FW_RESET_TIME);

this should probably just be

wait_for_completion(&data->fw_load_completion);

rather than timing out (the MXT_FW_RESET_TIME may not be an appropriate
length anyway)

cheers

Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/