linux-kernel - Re: [PATCH] pwm: samsung: Use MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5553F0BD.1000606@collabora.co.uk>
Date:	Thu, 14 May 2015 02:47:57 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Thierry Reding <thierry.reding@...il.com>
CC:	Olof Johansson <olof@...om.net>,
	Doug Anderson <dianders@...omium.org>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pwm@...r.kernel.org
Subject: Re: [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF
 modalias

Hello Krzysztof,

On 05/14/2015 02:37 AM, Krzysztof Kozlowski wrote:
> On 14.05.2015 09:32, Javier Martinez Canillas wrote:
>> If the pwm-samsung driver is built as a module, modalias information is
>> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
>> macro to export the OF device ID so the module contains that information.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> 
> I think many other Maxim/S[25]M drivers for Samsung boards may also be
> affected... Probably they should also be updated.
>

Yeah, I detected these since I'm preparing a series to reduce the delta
between exynos_defconfig and multi_v7_defconfig. And found these issues
since current multi_v7 policy is to build as much as possible as a module.

I think is unfortunate how many drivers are not providing proper module
aliases information and so building them as a module is less useful since
user-space can't associate the module with the modalias uevents to autoload.

Anyway, I'll take a look for other drivers and see if I can post similar
patches but now at least all the peripherals in the Exynos5 Chromebooks
are working when their drivers are built as a module.

> Best regards,
> Krzysztof
> 

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/