linux-kernel - Re: [PATCH] x86, mce, amd: Read mcgstatus before we log the error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5554B787.4020400@amd.com>
Date:	Thu, 14 May 2015 09:56:07 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<tony.luck@...el.com>, <tglx@...utronix.de>, <mingo@...hat.com>,
	<hpa@...or.com>, <x86@...nel.org>, <linux-edac@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, mce, amd: Read mcgstatus before we log the error

On 5/14/2015 4:50 AM, Borislav Petkov wrote:
> On Wed, May 13, 2015 at 12:37:04PM -0500, Aravind Gopalakrishnan wrote:
>>   
>>   	mce_setup(&m);
>> +	rdmsrl(MSR_IA32_MCG_STATUS, m.mcgstatus);
> Any meaningful bits in that MSR we wanna know when getting a
> thresholding or deferred error? Are they even defined?

Ah. Good point. RIPV is not defined for Deferred errors.
For thresholding, we'll hit the interrupt handler only if we hit the 
threshold and
it is not UC error (for which RIPV is not defined). Else, the counter 
would be incremented,
but it would cause a #MC anyway.

> If yes, RIPV should always be 1b, EIPV too, MCIP can't be set.
>
> -ENOMOREUSEFULBITS.
>

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/