linux-kernel - Re: [net-next PATCH] net: Reserve skb headroom and set skb->dev even if using __alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150514014320.GA20006@saruman.tx.rr.com>
Date:	Wed, 13 May 2015 20:43:20 -0500
From:	Felipe Balbi <balbi@...com>
To:	Kevin Hilman <khilman@...nel.org>
CC:	Alexander Duyck <alexander.h.duyck@...hat.com>,
	<linux-kernel@...r.kernel.org>, <balbi@...com>,
	<davem@...emloft.net>, <tony@...mide.com>,
	<netdev@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [net-next PATCH] net: Reserve skb headroom and set skb->dev even
 if using __alloc_skb

On Wed, May 13, 2015 at 02:35:51PM -0700, Kevin Hilman wrote:
> Alexander Duyck <alexander.h.duyck@...hat.com> writes:
> 
> > When I had inlined __alloc_rx_skb into __netdev_alloc_skb and
> > __napi_alloc_skb I had overlooked the fact that there was a return in the
> > __alloc_rx_skb.  As a result we weren't reserving headroom or setting the
> > skb->dev in certain cases.  This change corrects that by adding a couple of
> > jump labels to jump to depending on __alloc_skb either succeeding or failing.
> >
> > Fixes: 9451980a6646 ("net: Use cached copy of pfmemalloc to avoid accessing page")
> > Reported-by: Felipe Balbi <balbi@...com>
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> 
> Tested this on top of next-20150513 on an ARM/OMAP
> (am335x-boneblack.dts) an it fixes the boot problem for me.
> 
> Tested-by: Kevin Hilman <khilman@...aro.org>

Yeah, I know it's too late, but I also tested on my AM437x SK.

Tested-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)