linux-kernel - Re: [PATCH v5 1/6] x86/mm/pat: use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150514155534.GV23057@wotan.suse.de>
Date:	Thu, 14 May 2015 17:55:34 +0200
From:	"Luis R. Rodriguez" <mcgrof@...e.com>
To:	"Elliott, Robert (Server Storage)" <Elliott@...com>, bp@...e.de
Cc:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"plagnioj@...osoft.com" <plagnioj@...osoft.com>,
	"tomi.valkeinen@...com" <tomi.valkeinen@...com>,
	"daniel.vetter@...el.com" <daniel.vetter@...el.com>,
	"airlied@...ux.ie" <airlied@...ux.ie>,
	"dledford@...hat.com" <dledford@...hat.com>,
	"awalls@...metrocast.net" <awalls@...metrocast.net>,
	"syrjala@....fi" <syrjala@....fi>,
	"luto@...capital.net" <luto@...capital.net>,
	"mst@...hat.com" <mst@...hat.com>,
	"cocci@...teme.lip6.fr" <cocci@...teme.lip6.fr>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Juergen Gross <jgross@...e.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Dave Airlie <airlied@...hat.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends

On Thu, May 07, 2015 at 03:36:15AM +0000, Elliott, Robert (Server Storage) wrote:
> > From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-
> > owner@...r.kernel.org] On Behalf Of Luis R. Rodriguez
> > Sent: Thursday, April 30, 2015 3:25 PM
> > Subject: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends
> > 
> ...
> > -			printk(KERN_ERR "%s:%d map pfn expected mapping
> > type %s"
> > -				" for [mem %#010Lx-%#010Lx], got %s\n",
> > -				current->comm, current->pid,
> > -				cattr_name(want_pcm),
> > -				(unsigned long long)paddr,
> > -				(unsigned long long)(paddr + size - 1),
> > -				cattr_name(pcm));
> > +			pr_err("%s:%d map pfn expected mapping type %s"
> > +			       " for [mem %#010Lx-%#010Lx], got %s\n",
> 
> Since the patch joins some other print format strings split across 
> lines (which checkpatch allows), you might want to join this one too.
> 
> ...
> > diff --git a/arch/x86/mm/pat_rbtree.c b/arch/x86/mm/pat_rbtree.c
> ...
> >  failure:
> > -	printk(KERN_INFO "%s:%d conflicting memory types "
> > +	pr_info("%s:%d conflicting memory types "
> >  		"%Lx-%Lx %s<->%s\n", current->comm, current->pid, start,
> >  		end, cattr_name(found_type), cattr_name(match->type));
> 
> and that one.

I have adjusted this.

Boris, would you like a v6 re-spin on this series?  Or just this patch, or
anthing else? FWIW since I keep having to re-do patches / rebase after a while
and the entire kill-mtrr series is large with tons of parts I've set out a tree
with all pending mtrr changes.  The kill-mtrr-v5-20150514 can be used:

https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git

When needed I'll just fetch linux-next and rebase --onto that day's
origin/master.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/