linux-kernel - Re: [PATCH] ASoC: codecs-ac97: make selectable in config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150514192847.GV2761@sirena.org.uk>
Date:	Thu, 14 May 2015 20:28:47 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
	alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Brian Austin <brian.austin@...rus.com>,
	Bard Liao <bardliao@...ltek.com>,
	Oder Chiou <oder_chiou@...ltek.com>,
	Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org,
	Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config

On Thu, May 14, 2015 at 09:24:15PM +0200, Lars-Peter Clausen wrote:
> On 05/14/2015 09:10 PM, Mark Brown wrote:

> >Does the select from SND_SOC_AC97_BUS actually happen if it is selected
> >by SND_SOC_ALL_CODECS?  That's the issue, if it works now it's a
> >relatively recent thing.

> I'm not sure I fully understand what you mean.

> The Kconfig entry for the CODEC has no 'depends on'. It does a 'select
> SND_SOC_AC97_BUS', which means all built time dependencies are pulled in
> this way. So if SND_SOC_ALL_CODECS selects the CODEC unconditionally that
> should work fine, since no dependencies are bypassed.

No, it's not just dependencies but also selects that get ignored (or
used to anyway like I say) - a select just forces the symbol on.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)