[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150514193445.GW23057@wotan.suse.de>
Date: Thu, 14 May 2015 21:34:45 +0200
From: "Luis R. Rodriguez" <mcgrof@...e.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: "Luis R. Rodriguez" <mcgrof@...not-panic.com>,
ming.lei@...onical.com, rusty@...tcorp.com.au,
torvalds@...ux-foundation.org, dhowells@...hat.com,
seth.forshee@...onical.com, linux-kernel@...r.kernel.org,
pebolle@...cali.nl, linux-wireless@...r.kernel.org,
gregkh@...uxfoundation.org, jlee@...e.com, tiwai@...e.de,
casey@...aufler-ca.com, keescook@...omium.org, mjg59@...f.ucam.org,
akpm@...ux-foundation.org, Kyle McMartin <kyle@...nel.org>,
Bruce Allan <bruce.w.allan@...el.com>,
Tadeusz Struk <tadeusz.struk@...el.com>,
John Griffin <john.griffin@...el.com>
Subject: Re: [RFC v2 3/6] crypto: qat - address recursive dependency when fw
signing is enabled
On Thu, May 14, 2015 at 11:04:15AM +0800, Herbert Xu wrote:
> On Wed, May 13, 2015 at 11:23:53AM -0700, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@...e.com>
> >
> > We're going to add firmware module signing support, but when we do
> > this we end up with the following recursive dependency. Fix this by
> > just depending on FW_LOADER, which is typically always enabled
> > anyway. We do this as a compromise for now as FW_LOADER is only
> > selectable when EXPERT is enabled and the recursive dependency issue
> > below is actually real and valid, its proper fix however requires
> > a bit of work.
> >
> > This technically means this change is likely welcomed for other
> > parts of the kernel but this is really only needed for now here.
>
> Nack. Either fix kbuild or make every user of FW_LOADER use
> a dependency. Singling out a single crypto device makes zero
> sense.
I think that's fair... Paul, did you get to look into the
recursive issue some more by any chance? Any preference for
what path to take here?
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists