linux-kernel - Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5554FDB4.50809@broadcom.com>
Date:	Thu, 14 May 2015 12:55:32 -0700
From:	Jonathan Richardson <jonathar@...adcom.com>
To:	Mark Brown <broonie@...nel.org>
CC:	Scott Branden <sbranden@...adcom.com>,
	Dmitry Torokhov <dtor@...gle.com>,
	Anatol Pomazau <anatol@...gle.com>,
	Rob Herring <robh+dt@...nel.org>,
	"Pawel Moll" <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	<linux-kernel@...r.kernel.org>, <linux-spi@...r.kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

On 15-05-14 12:08 PM, Mark Brown wrote:
> On Thu, May 14, 2015 at 11:19:01AM -0700, Scott Branden wrote:
>> On 15-05-14 03:31 AM, Mark Brown wrote:
> 
>>> Chip vendors often say this sort of thing and then get surprised by what
>>> their users choose to do, and even if it only ever gets used with flash
>>> all it would take is some new flash command which can use full duplex
>>> for something.  Please write the code so it at least tries to handle
>>> full duplex operation, if you can't test it fully that's not the end of
>>> the world.  It doesn't look like it should be particularly difficult.
> 
>> Yes, there is always room for improvements in code.  In this case - it
>> really is not worth our time to add code we can't test.  We try to deliver
>> code that we can test and actually works.  Yes, if anyone needs to use the
> 
> While I try to not apply code that has obvious problems with silent data
> corruption in it which is what we have just now.
> 
>> mspi for full duplex operation code can be added in the future - it is
>> software.  This block has gone through many generations of our SoCs and has
>> only been used for this purpose - the bootROM boots from this SPI only.  It
>> is dedicated for this purpose.
> 
> All it takes is one hardware engineer who sees a SPI controller and a
> GPIO they can use for chip select; I wouldn't be so sure that nobody
> ever fixed this up locally (or happened to use a device that only needed
> single duplex).
> 

Hi Mark. Would it help if we just set the flags to half duplex using
SPI_MASTER_HALF_DUPLEX when we register the master?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/