| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5555A7DA.2090800@huawei.com> Date: Fri, 15 May 2015 16:01:30 +0800 From: He Kuang <hekuang@...wei.com> To: Jiri Olsa <jolsa@...hat.com> CC: hekuang <hekuang@...o.com>, <acme@...nel.org>, <jolsa@...nel.org>, <mingo@...hat.com>, <a.p.zijlstra@...llo.nl>, <wangnan0@...wei.com>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins On 2015/5/14 21:31, Jiri Olsa wrote: > On Thu, May 14, 2015 at 08:56:15PM +0800, He Kuang wrote: > > SNIP > >>>> It seems new targets are needed. In the v2 patch, >>> >>> hum, I dont get it.. why ? >>> >>> dynamic-list-file gets rebuilt any time plugins are rebuilt.. >>> why not keep just the 'plugins' dependency? >> >> You can test your patch as following steps: >> >> $ touch ../lib/traceevent/plugin_function.c >> $ make >> CC plugin_function.o >> LD plugin_function-in.o >> LINK plugin_function.so >> GEN libtraceevent-dynamic-list >> >> perf is not rebuilt. There should be a 'GEN perf', right? > > hum, right.. so this is separated bug that was there even > without your change. I tried to kick my change to address > that and ended up with what you sent in v2 ;-) > > I have another comment for your v2, which I'll send right away > > thanks, > jirka > Ok, please review the new version. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists