linux-kernel - Re: [patch] regulator: max77686: fix a shift wrapping bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <5555C814.7030405@samsung.com>
Date:	Fri, 15 May 2015 19:19:00 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] regulator: max77686: fix a shift wrapping bug

Hi Dan,

On 05/15/2015 06:25 PM, Dan Carpenter wrote:
> We need to be able to handle more than 32 bits here because "id" can go
> up to MAX77686_BUCK9 (34).  ->gpio_enabled is a u64 so that's fine
> already.
> 
> Fixes: 3307e9025d29 ('regulator: max77686: Add GPIO control')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c
> index 23b7c06..59b3210 100644
> --- a/drivers/regulator/max77686.c
> +++ b/drivers/regulator/max77686.c
> @@ -121,7 +121,7 @@ static unsigned int max77686_map_normal_mode(struct max77686_data *max77686,
>  	case MAX77686_BUCK8:
>  	case MAX77686_BUCK9:
>  	case MAX77686_LDO20 ... MAX77686_LDO22:
> -		if (max77686->gpio_enabled & (1 << id))
> +		if (max77686->gpio_enabled & (1ULL << id))
>  			return MAX77686_GPIO_CONTROL;
>  	}
>  
> @@ -277,7 +277,7 @@ static int max77686_of_parse_cb(struct device_node *np,
>  	}
>  
>  	if (gpio_is_valid(config->ena_gpio)) {
> -		max77686->gpio_enabled |= (1 << desc->id);
> +		max77686->gpio_enabled |= (1ULL << desc->id);
>  
>  		return regmap_update_bits(config->regmap, desc->enable_reg,
>  					  desc->enable_mask,
> 

Looks good to me.

Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/