linux-kernel - [PATCH v3 1/2] kernel/panic: call the 2nd crash_kexec() only if crash_kexec_post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150515110143.8431.38836.stgit@localhost6.localdomain6>
Date:	Fri, 15 May 2015 20:01:44 +0900
From:	HATAYAMA Daisuke <d.hatayama@...fujitsu.com>
To:	akpm@...ux-foundation.org, ebiederm@...ssion.com,
	vgoyal@...hat.com, mingo@...nel.org
Cc:	masami.hiramatsu.pt@...achi.com, hidehiro.kawai.ez@...achi.com,
	kexec@...ts.infradead.org, linux-kernel@...r.kernel.org,
	bhe@...hat.com
Subject: [PATCH v3 1/2] kernel/panic: call the 2nd crash_kexec() only if
 crash_kexec_post_notifiers is enabled

For compatibility with the behaviour before the commit
f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45, the 2nd crash_kexec() should
be called only if crash_kexec_post_notifiers is enabled.

Note that crash_kexec() returns immediately if kdump crash kernel is
not loaded, so in this case, this patch makes no functionality change,
but the point is to make it explicit, from the caller panic() side,
that the 2nd crash_kexec() does nothing.

Signed-off-by: HATAYAMA Daisuke <d.hatayama@...fujitsu.com>
Suggested-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/panic.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index 8136ad7..774614f 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -142,7 +142,8 @@ void panic(const char *fmt, ...)
 	 * Note: since some panic_notifiers can make crashed kernel
 	 * more unstable, it can increase risks of the kdump failure too.
 	 */
-	crash_kexec(NULL);
+	if (crash_kexec_post_notifiers)
+		crash_kexec(NULL);
 
 	bust_spinlocks(0);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/