linux-kernel - Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5555ED4F.5070003@roeck-us.net>
Date:	Fri, 15 May 2015 05:57:51 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>,
	LINUXKERNEL <linux-kernel@...r.kernel.org>,
	LINUXWATCHDOG <linux-watchdog@...r.kernel.org>,
	Wim Van Sebroeck <wim@...ana.be>
CC:	Alessandro Zummo <a.zummo@...ertech.it>,
	DEVICETREE <devicetree@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	LINUXINPUT <linux-input@...r.kernel.org>,
	Lee Jones <lee.jones@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	RTCLINUX <rtc-linux@...glegroups.com>,
	Rob Herring <robh+dt@...nel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Support Opensource <Support.Opensource@...semi.com>
Subject: Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

Hi Steve,

On 05/15/2015 01:13 AM, Opensource [Steve Twiss] wrote:
> Hi Guenter,
>
> Thank you for your comments again,
> Here are my responses.
>
> Regards,
> Steve
>
> On 15 May 2015 03:13, Guenter Roeck
>> Subject: Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver
>>
>
> [...]
>

[ ... ]

>>> +
>>> +	irq = platform_get_irq_byname(pdev, "WDG_WARN");
>>> +	if (irq < 0) {
>>> +		dev_err(wdt->hw->dev, "Failed to get IRQ.\n");
>>> +		ret = irq;
>>> +		goto error;
>>
>> Just return; the label does not serve a useful purpose. Same for the other
>> goto statements below.
>
> Agreed. This is changed now.
>
>> Also, is the interrupt mandatory ? All it does is to display a message.
>> Looks very optional to me.
>
> It is a place holder for something more application specific.
> I could remove it, but I figured it would just get re-added when somebody takes the
> driver and modifies it for their needs.
>
> If this is a problem however, it can go.
> Please advise ..
>

Then this someone should add the code. For the time being, it just increases
kernel size and may cause the driver to fail for no good reason. Plus, given
the driver apparently works without interrupt, even then it should be optional,
and the driver does not have to fail loading if it is not supported on a
given platform.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/