linux-kernel - Re: [PATCH 1/6] Documentation: add sbsa-gwdt.txt documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8715806.mTJfA5WAcP@wuerfel>
Date:	Fri, 15 May 2015 16:06:29 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	fu.wei@...aro.org
Cc:	Suravee.Suthikulpanit@....com, linaro-acpi@...ts.linaro.org,
	linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	tekkamanninja@...il.com, graeme.gregory@...aro.org,
	al.stone@...aro.org, hanjun.guo@...aro.org, timur@...eaurora.org,
	ashwin.chaugule@...aro.org, linux@...ck-us.net,
	vgandhi@...eaurora.org, wim@...ana.be, jcm@...hat.com,
	leo.duran@....com, corbet@....net
Subject: Re: [PATCH 1/6] Documentation: add sbsa-gwdt.txt documentation

On Friday 15 May 2015 19:08:05 fu.wei@...aro.org wrote:
> From: Fu Wei <fu.wei@...aro.org>
> 
> The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for
> introducing SBSA(Server Base System Architecture) Generic Watchdog
> device node info into FDT
> 
> Signed-off-by: Fu Wei <fu.wei@...aro.org>

Looks good, just one minor comment:

> +Optional properties
> +- timeout-sec : Watchdog pre-timeout and timeout values (in seconds).
> +	The first is timeout values, then pre-timeout.

Please update Documentation/watchdog/watchdog-kernel-api.txt as well, to
mention the second number in the timeout-sec property.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/