linux-kernel - Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6af49d55159182668c21480e0fbaa85c@agner.ch>
Date:	Fri, 15 May 2015 18:01:19 +0200
From:	Stefan Agner <stefan@...er.ch>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	shawn.guo@...aro.org, kernel@...gutronix.de, jason@...edaemon.net,
	marc.zyngier@....com, linux@....linux.org.uk,
	u.kleine-koenig@...gutronix.de, olof@...om.net, arnd@...db.de,
	daniel.lezcano@...aro.org, mark.rutland@....com,
	pawel.moll@....com, robh+dt@...nel.org,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	mcoquelin.stm32@...il.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

On 2015-05-15 12:39, Thomas Gleixner wrote:
> On Sat, 9 May 2015, Stefan Agner wrote:
>> -	irq_chip_unmask_parent(data);
>> +	if (parent->chip->irq_enable)
>> +		parent->chip->irq_enable(parent);
>> +	else
>> +		parent->chip->irq_unmask(parent);
> 
> Why are you not creating irq_chip_enable_parent() which would have
> been the proper function anyway?
> 

Will add that...

Btw, have you had a chance to look at 1/12? I added a helper there too
to allow make use of generic chip with IRQ domain hierarchy. In case you
are fine with that general appraoch I will send an updated version of
the patchset with the irq_chip_enable_parent helper soon. 

--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/