linux-kernel - Re: [Linux-nvdimm] [PATCH v2 03/20] nd_acpi, nfit-test: manufactured NFITs for interface development

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49pp61wptt.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 15 May 2015 16:25:34 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	linux-nvdimm@...1.01.org, linux-acpi@...r.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Robert Moore <robert.moore@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [Linux-nvdimm] [PATCH v2 03/20] nd_acpi, nfit-test: manufactured NFITs for interface development

Dan Williams <dan.j.williams@...el.com> writes:

> +config NFIT_TEST
> +	tristate "NFIT TEST: Manufactured NFIT for interface testing"
> +	depends on DMA_CMA
> +	depends on LIBND=m
> +	depends on ND_ACPI
> +	depends on m
> +	help
> +	  For development purposes register a manufactured
> +	  NFIT table to verify the resulting device model topology.
> +	  Note, this module arranges for ioremap_cache() to be
> +	  overridden locally to allow simulation of system-memory as an
> +	  io-memory-resource.
> +
> +	  Note, this test expects to be able to find at least 256MB of
> +	  CMA space (CONFIG_CMA_SIZE_MBYTES, cma=) or it will fail to
> +	  load.
> +
> +	  Say N unless you are doing development of the 'nd' subsystem.
> +

Too many TLAs.  I'm guessing CMA means Conventional Memory Area to you.
To me it means contiguous memory allocator.  Anyway, please define
acronyms when you use them, especially in help text.  The help text also
doesn't really explain where it will find this memory.  Would it be
possible to provide more direction there?

I don't have any useful commentary on the patch itself.  I do wonder if
you shouldn't move this to the end, as it's hardly an integral part of
the patch set.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/