linux-kernel - Re: [PATCH 3.12 137/142] mmc: sh_mmcif: Fix timeout value for command request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555728A8.4030300@suse.cz>
Date:	Sat, 16 May 2015 13:23:20 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Albino Biasutti Neto <bino@...eup.net>
CC:	stable@...r.kernel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Takeshi Kihara <takeshi.kihara.df@...esas.com>,
	Simon Horman <horms+renesas@...ge.net.au>,
	Yoshihiro Kaneko <ykaneko0929@...il.com>,
	Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH 3.12 137/142] mmc: sh_mmcif: Fix timeout value for command
 request

On 05/16/2015, 01:05 PM, Albino Biasutti Neto wrote:
> 2015-05-16 4:38 GMT-03:00 Jiri Slaby <jslaby@...e.cz>:
>> commit bad4371d87d1d1ed1aecd9c9cc21c41ac3f289c8 upstream.
>>
>> f9fd54f22e ("mmc: sh_mmcif: Use msecs_to_jiffies() for host->timeout")
>> changed the timeout value from 1000 jiffies to 1s. In the case where
>> HZ is 1000 the values are the same. However, for smaller HZ values the
>> timeout is now smaller, 1s instead of 10s in the case of HZ=100.
>>
>> Since the timeout occurs in spite of a normal data transfer a timeout of
>> 10s seems more appropriate. This restores the previous timeout in the
>> case where HZ=100 and results in an increase over the previous timeout
>> for larger values of HZ.
>>
>> Fixes: f9fd54f22e ("mmc: sh_mmcif: Use msecs_to_jiffies() for host->timeout")
> 
> What is best 1s or 10s ? is 1s. The less time is faster, but HZ=100
> not 1000. 10s the longer answer.
> 
> True ?

Sorry, what?

-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/