[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1431821187-21648-1-git-send-email-dmitry.kalinkin@gmail.com>
Date: Sun, 17 May 2015 03:06:27 +0300
From: Dmitry Kalinkin <dmitry.kalinkin@...il.com>
To: linux-kernel@...r.kernel.org, cocci@...teme.lip6.fr
Cc: Julia Lawall <Julia.Lawall@...6.fr>,
Gilles Muller <Gilles.Muller@...6.fr>,
Nicolas Palix <nicolas.palix@...g.fr>,
Michal Marek <mmarek@...e.cz>,
Dmitry Kalinkin <dmitry.kalinkin@...il.com>
Subject: [PATCH] coccinelle: api: add vma_pages.cocci
This semantic patch replaces explicit computations of vma page count
with explicit function call.
Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@...il.com>
---
scripts/coccinelle/api/vma_pages.cocci | 66 ++++++++++++++++++++++++++++++++++
1 file changed, 66 insertions(+)
create mode 100644 scripts/coccinelle/api/vma_pages.cocci
diff --git a/scripts/coccinelle/api/vma_pages.cocci b/scripts/coccinelle/api/vma_pages.cocci
new file mode 100644
index 0000000..2b7a748
--- /dev/null
+++ b/scripts/coccinelle/api/vma_pages.cocci
@@ -0,0 +1,66 @@
+/// Use vma_pages function on vma object instead of explicit computation.
+// Confidence: High
+// Keywords: vma_pages vma
+
+// Based on resource_size.cocci
+
+virtual context
+virtual patch
+virtual org
+virtual report
+
+//----------------------------------------------------------
+// For context mode
+//----------------------------------------------------------
+
+@...ontext depends on context && !patch && !org@
+struct vm_area_struct *vma;
+@@
+
+* (vma->vm_end - vma->vm_start) >> PAGE_SHIFT
+
+//----------------------------------------------------------
+// For patch mode
+//----------------------------------------------------------
+
+@...atch1 depends on !context && patch && !org@
+struct vm_area_struct *vma;
+@@
+
+- ((vma->vm_end - vma->vm_start) >> PAGE_SHIFT)
++ vma_pages(vma)
+
+@...atch2 depends on !context && patch && !org@
+struct vm_area_struct *vma;
+@@
+
+- (vma->vm_end - vma->vm_start) >> PAGE_SHIFT
++ vma_pages(vma)
+
+//----------------------------------------------------------
+// For org mode
+//----------------------------------------------------------
+
+@...rg depends on !context && !patch && (org || report)@
+struct vm_area_struct *vma;
+position p;
+@@
+
+ (vma->vm_end@p - vma->vm_start) >> PAGE_SHIFT
+
+@...ipt:python depends on report@
+p << r_org.p;
+x << r_org.vma;
+@@
+
+msg="ERROR: Missing vma_pages with %s" % (x)
+coccilib.report.print_report(p[0], msg)
+
+@...ipt:python depends on org@
+p << r_org.p;
+x << r_org.vma;
+@@
+
+msg="ERROR with %s" % (x)
+msg_safe=msg.replace("[","@(").replace("]",")")
+coccilib.org.print_todo(p[0], msg_safe)
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists