linux-kernel - Re: [PATCH] staging: rtl8712: Use ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150517232710.GA27330@kroah.com>
Date:	Sun, 17 May 2015 16:27:10 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jagan Teki <jteki@...nedev.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Larry Finger <Larry.Finger@...inger.net>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>
Subject: Re: [PATCH] staging: rtl8712: Use ether_addr_copy() instead of
 memcpy()

On Mon, May 18, 2015 at 02:27:01AM +0530, Jagan Teki wrote:
> This patch fixes to use ether_addr_copy() instead of memcpy()
> 
> Encounter this by applying checkpatch.pl against this file:
>   WARNING: Prefer ether_addr_copy() over memcpy()
>   if the Ethernet addresses are __aligned(2)
> 
> Signed-off-by: Jagan Teki <jteki@...nedev.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Larry Finger <Larry.Finger@...inger.net>
> Cc: Florian Schilhabel <florian.c.schilhabel@...glemail.com>
> ---
>  drivers/staging/rtl8712/os_intfs.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

You need to prove that the addresses are aligned, please do so in the
changelog entry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/