linux-kernel - Re: [PATCH] Staging: unisys: fix function declaration format in visorchipset.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <555A7430.9030105@wimdewith.com>
Date:	Tue, 19 May 2015 01:22:24 +0200
From:	Wim de With <nauxuron@...dewith.com>
To:	Jes Sorensen <Jes.Sorensen@...hat.com>
CC:	benjamin.romer@...sys.com, david.kershner@...sys.com,
	gregkh@...uxfoundation.org, sparmaintainer@...sys.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: unisys: fix function declaration format in visorchipset.c

On 18-5-2015 12:45, Jes Sorensen wrote:
> Wim de With <nauxuron@...dewith.com> writes:
>> This is a patch that fixes the function declarations in
>> visorbus/visorchipset.c by removing newlines after the function return
>> type
> 
> This patch doesn't fix things, it makes things worse!
> 
> If you want to post patches to this, do it properly and check the output
> first.
> 
> NACK
> 
> Jes

But how is line breaking in function headers supposed to be done? The
coding style documentation specifically state the following:
"Descendants are always substantially shorter than the parent and are
placed substantially to the right. The same applies to function headers
with a long argument list."

I really don't want to bother you with trivial patches, especially when
they are incorrect, but I am trying to learn something, so I hope you
will help me out.

Wim









--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/