linux-kernel - Re: [PATCH] drm/exynos: dp: Lower level of EDID read success message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 19 May 2015 08:30:14 +0900
From:	"Jingoo Han" <jingoohan1@...il.com>
To:	"'Krzysztof Kozlowski'" <k.kozlowski@...sung.com>
Cc:	"'Inki Dae'" <inki.dae@...sung.com>,
	"'Joonyoung Shim'" <jy0922.shim@...sung.com>,
	"'Seung-Woo Kim'" <sw0312.kim@...sung.com>,
	"'Kyungmin Park'" <kyungmin.park@...sung.com>,
	"'David Airlie'" <airlied@...ux.ie>,
	"'Kukjin Kim'" <kgene.kim@...sung.com>,
	<dri-devel@...ts.freedesktop.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/exynos: dp: Lower level of EDID read success message 

> Don't pollute the dmesg with EDID read success message as an error.
> Printing as debug should be fine.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Right, dev_err() is not right.
Thank you for sending the patch.

Acked-by: Jingoo Han <jingoohan1@...il.com>

Best regards,
Jingoo Han

> ---
>  drivers/gpu/drm/exynos/exynos_dp_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index 441ef06b8894..30feb7d06624 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -195,7 +195,7 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp)
>  		}
>  	}
>  
> -	dev_err(dp->dev, "EDID Read success!\n");
> +	dev_dbg(dp->dev, "EDID Read success!\n");
>  	return 0;
>  }
>  
> -- 
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/