linux-kernel - Re: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150518.195230.2247842502863025488.davem@davemloft.net>
Date:	Mon, 18 May 2015 19:52:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ddaney@...iumnetworks.com
Cc:	aleksey.makarov@...iga.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, david.daney@...ium.com,
	sgoutham@...ium.com, mjc@...ihalf.com,
	ganapatrao.kulkarni@...iumnetworks.com, tomasz.nowicki@...aro.org,
	rrichter@...ium.com, kamil@...ihalf.com,
	tsrinivasulu@...iumnetworks.com, svangala@...ium.com,
	rric@...nel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v3 2/2] net: Adding support for Cavium
 ThunderX network controller

From: David Daney <ddaney@...iumnetworks.com>
Date: Mon, 18 May 2015 14:52:30 -0700

> As I see it there are two options:
> 
> 1) Keep the writeq_relaxed()/readq_relaxed(), but add a comment about
> why they are safe.
> 
> 2) Change the patch so that we are using writeq()/readq() and suffer a
> decrease in performance.

I want a detailed comment added, so #1 would be my choice.

There are more than one set of register accessors, so make sure you
annotate them all.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/