linux-kernel - Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150518065158.GA17391@unicorn.suse.cz>
Date:	Mon, 18 May 2015 08:51:58 +0200
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Alex Dowad <alexinbeijing@...il.com>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Hans Verkuil <hans.verkuil@...co.com>,
	"Lad, Prabhakar" <prabhakar.csengg@...il.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Ramakrishnan Muthukrishnan <ramakrmu@...co.com>,
	"open list:MEDIA INPUT INFRA..." <linux-media@...r.kernel.org>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Clarify expression which uses both multiplication and
 pointer dereference

On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote:
> This fixes a checkpatch style error in vpfe_buffer_queue_setup.
> 
> Signed-off-by: Alex Dowad <alexinbeijing@...il.com>
> ---
>  drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> index 06d48d5..04a687c 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> @@ -1095,7 +1095,7 @@ vpfe_buffer_queue_setup(struct vb2_queue *vq, const struct v4l2_format *fmt,
>  	size = video->fmt.fmt.pix.sizeimage;
>  
>  	if (vpfe_dev->video_limit) {
> -		while (size * *nbuffers > vpfe_dev->video_limit)
> +		while (size * (*nbuffers) > vpfe_dev->video_limit)
>  			(*nbuffers)--;
>  	}
>  	if (pipe->state == VPFE_PIPELINE_STREAM_CONTINUOUS) {

Style issue aside, is there a reason not to use

		if (size * *nbuffers > vpfe_dev->video_limit)
			*nbuffers = vpfe_dev->video_limit / size;

instead?

                                                          Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/