linux-kernel - Re: [PATCH 05/14] ceph: Use kvfree() in ceph_put_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <6867EAD8-BD79-47F5-BD72-8BE21C5B5D21@redhat.com>
Date:	Mon, 18 May 2015 14:59:47 +0800
From:	"Yan, Zheng" <zyan@...hat.com>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Sage Weil <sage@...hat.com>
Subject: Re: [PATCH 05/14] ceph: Use kvfree() in ceph_put_page_vector()


> On May 16, 2015, at 02:35, Pekka Enberg <penberg@...nel.org> wrote:
> 
> Use kvfree instead of open-coding it.
> 
> Cc: "Yan, Zheng" <zyan@...hat.com>
> Cc: Sage Weil <sage@...hat.com>
> Signed-off-by: Pekka Enberg <penberg@...nel.org>
> ---
> net/ceph/pagevec.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c
> index 096d914..d4f5f22 100644
> --- a/net/ceph/pagevec.c
> +++ b/net/ceph/pagevec.c
> @@ -51,10 +51,7 @@ void ceph_put_page_vector(struct page **pages, int num_pages, bool dirty)
> 			set_page_dirty_lock(pages[i]);
> 		put_page(pages[i]);
> 	}
> -	if (is_vmalloc_addr(pages))
> -		vfree(pages);
> -	else
> -		kfree(pages);
> +	kvfree(pages);
> }
> EXPORT_SYMBOL(ceph_put_page_vector);

Thanks. but Ilya Dryomov has already submitted a similar patch.

> 
> -- 
> 2.1.0
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/