linux-kernel - Re: [PATCH v2] Documentation/arch: Add kernel feature descriptions and arch support status under Documentation/features/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150518085423.GA24944@gmail.com>
Date:	Mon, 18 May 2015 10:54:23 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Michael Ellerman <mpe@...erman.id.au>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Josh Triplett <josh@...htriplett.org>,
	Borislav Petkov <bp@...en8.de>,
	Jonathan Corbet <corbet@....net>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...capital.net>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH v2] Documentation/arch: Add kernel feature descriptions
 and arch support status under Documentation/features/


* Michael Ellerman <mpe@...erman.id.au> wrote:

> > > Yes it is. I have my own version I've cobbled together for 
> > > powerpc, but this is much better.
> > 
> > Please double check the PowerPC support matrix for correctness (if 
> > you haven't yet):
> 
> It looks good except for:
> 
> >        rwsem-optimized:  |  ok  |                              Optimized asm/rwsem.h #  arch provides optimized rwsem APIs
> 
> I don't see an rwsem.h in powerpc anywhere?

Indeed, that slipped through. I fixed it to:

    triton:~/tip> cat Documentation/features/locking/rwsem-optimized/arch-support.txt 
    #
    # Feature name:          rwsem-optimized
    #         Kconfig:       Optimized asm/rwsem.h
    #         description:   arch provides optimized rwsem APIs
    #
        -----------------------
        |         arch |status|
        -----------------------
        |       alpha: |  ok  |
        |         arc: | TODO |
        |         arm: | TODO |
        |       arm64: | TODO |
        |       avr32: | TODO |
        |    blackfin: | TODO |
        |         c6x: | TODO |
        |        cris: | TODO |
        |         frv: | TODO |
        |     hexagon: | TODO |
        |        ia64: |  ok  |
        |        m32r: | TODO |
        |        m68k: | TODO |
        |       metag: | TODO |
        |  microblaze: | TODO |
        |        mips: | TODO |
        |     mn10300: | TODO |
        |       nios2: | TODO |
        |    openrisc: | TODO |
        |      parisc: | TODO |
        |     powerpc: | TODO |
        |        s390: |  ok  |
        |       score: | TODO |
        |          sh: |  ok  |
        |       sparc: |  ok  |
        |        tile: | TODO |
        |          um: | TODO |
        |   unicore32: | TODO |
        |         x86: |  ok  |
        |      xtensa: |  ok  |
        -----------------------

> And this is correct but a bit confusing:
> 
> >          irq-time-acct:  |  ok  |                           HAVE_IRQ_TIME_ACCOUNTING #  arch supports precise IRQ time accounting
> 
> I think you and Paul agreed it's "ok" on powerpc because we have
> VIRT_CPU_ACCOUNTING instead, but that's not obvious.

Ok, so I modified it to print '..' instead:

    triton:~/tip> cat Documentation/features/time/irq-time-acct/arch-support.txt
    #
    # Feature name:          irq-time-acct
    #         Kconfig:       HAVE_IRQ_TIME_ACCOUNTING
    #         description:   arch supports precise IRQ time accounting
    #
        -----------------------
        |         arch |status|
        -----------------------
        |       alpha: |  ..  |
        |         arc: | TODO |
        |         arm: |  ok  |
        |       arm64: |  ..  |
        |       avr32: | TODO |
        |    blackfin: | TODO |
        |         c6x: | TODO |
        |        cris: | TODO |
        |         frv: | TODO |
        |     hexagon: | TODO |
        |        ia64: |  ..  |
        |        m32r: | TODO |
        |        m68k: | TODO |
        |       metag: | TODO |
        |  microblaze: | TODO |
        |        mips: |  ok  |
        |     mn10300: | TODO |
        |       nios2: | TODO |
        |    openrisc: | TODO |
        |      parisc: |  ..  |
        |     powerpc: |  ..  |
        |        s390: |  ..  |
        |       score: | TODO |
        |          sh: | TODO |
        |       sparc: |  ..  |
        |        tile: |  ..  |
        |          um: | TODO |
        |   unicore32: | TODO |
        |         x86: |  ok  |
        |      xtensa: |  ok  |
        -----------------------

i.e. it's not marked as TODO, but not as supported either which would 
be misleading.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/