linux-kernel - Re: [PATCH] KVM: mips: use id_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5559BBD4.7010402@imgtec.com>
Date:	Mon, 18 May 2015 11:15:48 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Paolo Bonzini <pbonzini@...hat.com>,
	<linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>
CC:	<stable@...r.kernel.org>
Subject: Re: [PATCH] KVM: mips: use id_to_memslot correctly

Hi Paolo,

On 18/05/15 09:14, Paolo Bonzini wrote:
> The argument to KVM_GET_DIRTY_LOG is a memslot id; it may not
> match the position in the memslots array, which is sorted by
> gfn.
> 
> Cc: stable@...r.kernel.org
> Cc: James Hogan <james.hogan@...tec.com>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>

Reviewed-by: James Hogan <james.hogan@...tec.com>

(I have the same patch in my pile).

Thanks
James

> ---
>  arch/mips/kvm/mips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c
> index bb68e8d520e8..52f205ae1281 100644
> --- a/arch/mips/kvm/mips.c
> +++ b/arch/mips/kvm/mips.c
> @@ -982,7 +982,7 @@ int kvm_vm_ioctl_get_dirty_log(struct kvm *kvm, struct kvm_dirty_log *log)
>  
>  	/* If nothing is dirty, don't bother messing with page tables. */
>  	if (is_dirty) {
> -		memslot = &kvm->memslots->memslots[log->slot];
> +		memslot = id_to_memslot(kvm->memslots, log->slot);
>  
>  		ga = memslot->base_gfn << PAGE_SHIFT;
>  		ga_end = ga + (memslot->npages << PAGE_SHIFT);
> 


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)