| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5559C370.3050109@linux.vnet.ibm.com> Date: Mon, 18 May 2015 16:18:16 +0530 From: Anshuman Khandual <khandual@...ux.vnet.ibm.com> To: Anton Blanchard <anton@...ba.org> CC: mikey@...ling.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, shuahkh@....samsung.com Subject: Re: [PATCH V3 09/13] selftests, powerpc: Add test for DSCR value inheritence across fork On 05/18/2015 10:39 AM, Anton Blanchard wrote: > Hi Anshuman, > > Thanks for getting these testcases into the kernel. > >> This patch adds a test to verify that the changed DSCR value inside >> any process would be inherited to it's child process across the fork >> system call. > > One issue I do notice (a bug in my original test cases too), is that we > don't restore the DSCR on exit. I'm not sure we need to go to the > trouble of saving and restoring it, but we should at least get it back > to 0 when done. Will save/restore the system DSCR default before exiting. > > Also a tiny nit, no need for a newline in perror(): > > open() failed > : Permission denied > sure, will remove them. > With those changes you can add: > > Signed-off-by: Anton Blanchard <anton@...ba.org> > > to the patches based on my testcases. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists