linux-kernel - [PATCH v2] Add coccinelle script that makes sure that tables are NULL terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 May 2015 13:29:00 +0200
From:	Daniel Granat <d.granat@...sung.com>
To:	Julia.Lawall@...6.fr, cocci@...teme.lip6.fr,
	linux-kernel@...r.kernel.org
Cc:	Gilles.Muller@...6.fr, nicolas.palix@...g.fr,
	Daniel Granat <d.granat@...sung.com>
Subject: [PATCH v2] Add coccinelle script that makes sure that tables are NULL
 terminated

Signed-off-by: Daniel Granat <d.granat@...sung.com>
---
 scripts/coccinelle/misc/of_platform.cocci | 65 +++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)
 create mode 100644 scripts/coccinelle/misc/of_platform.cocci

diff --git a/scripts/coccinelle/misc/of_platform.cocci b/scripts/coccinelle/misc/of_platform.cocci
new file mode 100644
index 0000000..02c6195
--- /dev/null
+++ b/scripts/coccinelle/misc/of_platform.cocci
@@ -0,0 +1,65 @@
+/// Make sure that tables are NULL terminated
+//
+// Keywords: _device_id
+// Confidence: Medium
+// Options: --include-headers
+
+virtual report
+virtual patch
+
+@r depends on report@
+position p1;
+identifier var, arr;
+identifier name = {of_device_id, i2c_device_id, platform_device_id};
+expression E;
+@@
+
+(
+struct name arr[] = {
+	...,
+	{
+	.var = E,
+	}
+	@p1
+};
+|
+struct name arr[] = {
+	...,
+	{ ..., var, ... },
+	@p1
+};
+)
+
+@...ipt:python depends on report@
+p1 << r.p1;
+arr << r.arr;
+@@
+
+msg = "%s is not NULL terminated at line %s" % (arr, p1[0].line)
+coccilib.report.print_report(p1[0],msg)
+
+@p depends on patch@
+position p1;
+identifier var, arr;
+identifier name = {of_device_id, i2c_device_id, platform_device_id};
+expression E;
+@@
+
+(
+struct name arr[] = {
+	...,
+	{
+	.var = E,
+-	}
+	@p1
++	},
++	{},
+};
+|
+struct name arr[] = {
+	...,
+	{ ..., var, ... },
+	@p1
++	{},
+};
+)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/