linux-kernel - Re: [PATCH - RE-RESEND] IRQ: don't suspend nested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 May 2015 14:16:27 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	NeilBrown <neilb@...e.de>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	linux-kernel@...r.kernel.org,
	GTA04 owners <gta04-owner@...delico.com>,
	linux-pm@...r.kernel.org,
	Kalle Jokiniemi <kalle.jokiniemi@...lamobile.com>
Subject: Re: [PATCH - RE-RESEND] IRQ: don't suspend nested_thread irqs over
 system suspend.

On Sun, May 17, 2015 at 03:19:34PM +1000, NeilBrown wrote:
> 
> 
> Nested IRQs can only fire when the parent irq fires.
> So when the parent is suspended, there is no need to suspend
> the child irq.
> 
> Suspending nested irqs can cause a problem is they are suspended or
> resumed in the wrong order.
> If an interrupt fires while the parent is active but the child is
> suspended, then the interrupt will not be acknowledged properly
> and so an interrupt storm can result.
> This is particularly likely if the parent is resumed before
> the child, and the interrupt was raised during suspend.
> 
> Ensuring correct ordering would be possible, but it is simpler
> to just never suspend nested interrupts.

Looks sane to me, but it's Thomas' call.

FWIW:

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>

> 
> Signed-off-by: NeilBrown <neil@...wn.name>
> ---
> diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
> index 5204a6d1b985..d22786a6dbde 100644
> --- a/kernel/irq/pm.c
> +++ b/kernel/irq/pm.c
> @@ -123,6 +123,8 @@ void suspend_device_irqs(void)
>  		unsigned long flags;
>  		bool sync;
>  
> +		if (irq_settings_is_nested_thread(desc))
> +			continue;
>  		raw_spin_lock_irqsave(&desc->lock, flags);
>  		sync = suspend_device_irq(desc, irq);
>  		raw_spin_unlock_irqrestore(&desc->lock, flags);
> @@ -163,6 +165,8 @@ static void resume_irqs(bool want_early)
>  
>  		if (!is_early && want_early)
>  			continue;
> +		if (irq_settings_is_nested_thread(desc))
> +			continue;
>  
>  		raw_spin_lock_irqsave(&desc->lock, flags);
>  		resume_irq(desc, irq);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/