[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5559D8C5.9060407@metafoo.de>
Date: Mon, 18 May 2015 14:19:17 +0200
From: Lars-Peter Clausen <lars@...afoo.de>
To: Urs Fässler <urs.fassler@...esatwork.ch>,
jic23@...nel.org, angelo.compagnucci@...il.com
CC: iivanov@...sol.com, ezequiel.garcia@...tec.com,
jacob.jun.pan@...ux.intel.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: adc128s052: add support for adc122s021
> --- a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> @@ -1,7 +1,7 @@
> -* Texas Instruments' ADC128S052 ADC chip
> +* Texas Instruments' ADC128S052 and ADC122S021 ADC chip
>
> Required properties:
> - - compatible: Should be "ti,adc128s052"
> + - compatible: Should be "adc128s052" or "adc122s021"
Why are you removing the vendor prefix? The compatible string is not valid
without a vendor prefix.
> - reg: spi chip select number for the device
> - vref-supply: The regulator supply for ADC reference voltage
>
> @@ -11,7 +11,7 @@ Recommended properties:
>
> Example:
> adc@0 {
> - compatible = "ti,adc128s052";
> + compatible = "adc128s052";
Indention.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists