linux-kernel - Re: [PATCH] bfa: deinline __bfa_trc() and __bfa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5559E2C4.1020900@redhat.com>
Date:	Mon, 18 May 2015 15:01:56 +0200
From:	Denys Vlasenko <dvlasenk@...hat.com>
To:	Guenter Roeck <linux@...ck-us.net>,
	Vijaya Mohan Guvva <vmohan@...cade.com>
CC:	Fabian Frederick <fabf@...net.be>,
	Anil Gurumurthy <anil.gurumurthy@...gic.com>,
	Christoph Hellwig <hch@....de>,
	Ben Hutchings <ben@...adent.org.uk>,
	James Bottomley <JBottomley@...allels.com>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] bfa: deinline __bfa_trc() and __bfa_trc32()

On 05/18/2015 02:58 PM, Guenter Roeck wrote:
> On 05/18/2015 02:18 AM, Denys Vlasenko wrote:
>> __bfa_trc() compiles to 115 bytes of machine code.
>> With this .config: http://busybox.net/~vda/kernel_config
>> there are 1494 calls of __bfa_trc().
>>
>> __bfa_trc32() is very similar, so it is uninlined too.
>> However, it appears to be unused, therefore this patch
>> ifdefs it out.
>>
> Why not just remove it ?

I'm not familiar with the code, figured maintainers know better.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/