linux-kernel - Re: [PATCH][V3] ARM: pmu: fix memory leak due to early return not freeing irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5559E8AA.5080609@arm.com>
Date:	Mon, 18 May 2015 14:27:06 +0100
From:	Sudeep Holla <sudeep.holla@....com>
To:	Colin King <colin.king@...onical.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
CC:	Will Deacon <Will.Deacon@....com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Sudeep Holla <sudeep.holla@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][V3] ARM: pmu: fix memory leak due to early return not
 freeing irqs



On 18/05/15 13:57, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Recent commit 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about
> missing interrupt-affinity property for PPIs") introduced a memory
> leak of irqs on the "Don't bother with PPIs" return path. This issue
> was picked up by static analysis by cppcheck:
>
> [arch/arm/kernel/perf_event_cpu.c:315]: (error) Memory leak: irqs
>
> Instead, perform allocation of irqs after getting the irq hence
> removing need to clean up an allocation on the PPI affine return path.
>
> Fixes: 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about missing interrupt-affinity property for PPIs")

Will Deacon has similar patch[1] in Russell's patch tracker(8357/1)

Regards,
Sudeep

[1] 
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/342367.html
[2] http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8357/1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/