linux-kernel - Re: [patch] USB: devio: fix a condition in async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1505181027580.1579-100000@iolanthe.rowland.org>
Date:	Mon, 18 May 2015 10:42:12 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Dan Carpenter <dan.carpenter@...cle.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Oliver Neukum <oneukum@...e.de>,
	Chase Metzger <chasemetzger15@...il.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [patch] USB: devio: fix a condition in async_completed()

On Mon, 18 May 2015, Dan Carpenter wrote:

> Static checkers complain that the current condition is never true.  It
> seems pretty likely that it's a typo and "URB" was intended instead of
> "USB".
> 
> Fixes: 3d97ff63f899 ('usbdevfs: Use scatter-gather lists for large bulk transfers')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index 4b0448c..986abde 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -513,7 +513,7 @@ static void async_completed(struct urb *urb)
>  	snoop(&urb->dev->dev, "urb complete\n");
>  	snoop_urb(urb->dev, as->userurb, urb->pipe, urb->actual_length,
>  			as->status, COMPLETE, NULL, 0);
> -	if ((urb->transfer_flags & URB_DIR_MASK) == USB_DIR_IN)
> +	if ((urb->transfer_flags & URB_DIR_MASK) == URB_DIR_IN)
>  		snoop_urb_data(urb, urb->actual_length);
>  
>  	if (as->status < 0 && as->bulk_addr && as->status != -ECONNRESET &&

Yes, this most certainly is a typo.  Or rather, it is a copy of a typo 
originally introduced in commit 0880aef49e40 (USB: usbfs_snoop: add 
data logging back in).

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/